Update docs for assetsBalanceOf and maxWithdraw override #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is used to show accounts position in the dApp. It should not include any fees, just conversion of shares to assets.
To match ERC4626Upgradable contract implementation we use the same name of the `maxWithdraw` function to correctly override it in ERC4626Fees contract.
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 548a0fc |
nkuba
changed the title
dimpar
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes:
Improve documentation of assetsBalanceOf function
The function is used to show accounts' position in the dApp. It should
not include any fees, just the conversion of shares to assets.
Define maxWithdraw as a public function
To match ERC4626Upgradable contract implementation we use the same name
of the
maxWithdrawfunction to correctly override it in ERC4626Feescontract.