Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staking #52
Staking #52
Changes from 8 commits
05030cf
c80b77c
3ebb88b
c81cfd5
e754aca
f36c65c
14c14e1
02c2b3b
a9b6c0c
a4f9f87
028319f
f1a126b
684d667
829c3ed
ffaaba6
142c71f
b8a5b96
6132a7b
3a3cb35
e319a62
6837e74
c960102
c3c674d
58d2ddd
05b2091
a77b1a4
4c9eeec
249fb11
20086c6
63aac1b
e923f5e
5403ac3
6511fef
84bdf8e
ce16fba
c3a2bd8
b20259e
300b2a9
44b3f85
b84ee1b
3a312f7
05fb49d
277dc1e
eb91b4d
fbb2085
48eeed3
f7003b8
076a29c
961580b
9674f5e
9737ed8
d33c552
eef74bc
8a243cf
b812107
910a399
a868dce
567b52c
4889a03
9cac49c
88ee4d6
2750286
ed73109
68b81d0
e55dad2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add more test cases:
amountToStake
is zero,amountToStake
is one,amountToStake
is greater than the approved amount,receiver
is address zero,amountToStake
, staked it and tries to stake again, without another approval.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ERC46626 from OZ seems to allow that. Shouldn't we add this validation to the
deposit
function as a general rule?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ce16fba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should introduce a minimum deposit limit, we will add it in #59.