Allow passing referral in the URL for dApp #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DApp should detect by which partner it was opened. As a result, we will be able to customize the solutions depending on the partner.
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nkuba
reviewed
Aug 2, 2024
nkuba
requested changes
Aug 5, 2024
The application should be blocked when a user provides an intentionally incorrect referral.
When referral is set it should be a constant parameter in the URL. Therefore, a special hook was created to set this parameter in the navigate function.
nkuba
reviewed
Aug 7, 2024
|
I opened the dApp with no referral parameter https://deploy-preview-679--acre-dapp-testnet.netlify.app/. |
Fixed in 13de34b. |
We should not allow to open other modal windows when the global error modal is displayed.
kpyszkowski
approved these changes
Aug 12, 2024
michalinacienciala
approved these changes
Aug 12, 2024
nkuba
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #566
Acre will support the referral program. The referral value will be specified in the
refparameter in the URL. So when the user opens the dApp from the link https://stake.acre.fi/?ref=48450, the referral in the deposit flow should be set to the same value: 48450. The value of the referral was saved inlocalStorage. Some basic requirements:refparameter should allow numbers only up to max uint16.refparameter is not specified in the URL, the referral should be set to 0.nulland show a special modal window with an error. Navigation as well as the button to connect the account should be disabled from use.https://stake.acre.fi/?ref=48450, the referral in the deposit flow should be set to the same value:48450.Testing
refparameter is detected and set correctly inlocalStorage.0.null.