Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staking limits #68
Staking limits #68
Changes from all commits
2bdc9b5
5679d87
ae7b3fb
1765b6d
5494c44
15ff38d
0efc202
2fda404
7ae23cb
a5d022c
4a1de54
afc2323
7b907fe
2ecd47f
425a06f
8535cfe
ec6f06e
7516de4
331c1d3
17dc55a
f23a8e7
bff9665
9ed875d
f9f230a
b2c4a80
ea67712
43f583d
becb46e
1c42a37
a5903e3
a13b09f
31f74f2
5ec1b80
1f14cde
e8f7aa1
ab8d89c
0e33e4b
3266007
edd69cf
a373b59
f5a4429
fc5f585
1356fb0
54bcf17
0f8b830
53ca7fc
771553b
cc05de6
d2fcf4a
1140bcb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It says that
tBTC is pegged to BTC. As of now, max total supply of BTC is capped to 21M. No way BTC will reach max of uint256, unless something really ground breaking will happen to the whole crypto space. I don't think this check is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The max uint256 value is used to disable the limit. If the
maximumTotalAssets
is set to the maxuint256, the function won't bother with further calculations and immediately returns the max uint256 value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, but this is a view function that doesn't cost anything even if we do the calculation. I think it's a bit confusing and I know that uint256 is a big number, but logically it's not 100% correct, because if there are already assets in Acre, then
maxDeposit
should returnmaxuint256 - totalAssets
, not justmaxuint256
. I don't think it can bite us though. Up to you guys.