Deposit to ERC4626 Vaults #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dimpar
commented
Dec 8, 2023
•
dimpar
commented
- Added allocation functionality that deposits a single asset (tBTC) to an authorized vault
- Added and adjusted deployment scripts
- Changed unit tests and added an integration test that validates the flow of assets from Acre contract through Dispatcher that deposits assets to an authorized ERC4626 Vault
nkuba
reviewed
Dec 11, 2023
Renamed AcreRouter to Dispatcher and introduced an abstract contract called Router that will handle moving funds between Acre and Vaults. In order to deposit / redeem assets, Acre contract should approve assets for Dispatcher to spend and call depositToVault or redeemFromVault functions. These Acre's functions can be also called by a bot for rebalancing purposes.
dimpar
force-pushed
the
deposit-redeem-to-vaults
branch
from
f1f439d to
54a1562
Compare
dimpar
force-pushed
the
deposit-redeem-to-vaults
branch
from
c0485d9 to
1166e5e
Compare
Takes tBTC that was staked in Acre Core and routes assets to the authorized Yield Modules (ERC4626 Vaults). For now handling only 1 asset (tBTC).
dimpar
changed the title
nkuba
reviewed
Dec 28, 2023
When a new dispatcher is set, the tBTC allowance for the old one should be set to zero. Added tests.
Making Slither happy to avoid reentrancy warning.
nkuba
reviewed
Dec 29, 2023
nkuba
reviewed
Dec 29, 2023
Comment on lines
53
to
54
| const assetsToAllocate = to1e18(100) | ||
| const minSharesOut = to1e18(100) |
There was a problem hiding this comment.
Let's use different value for minSharesOut to be able to test if the Router actually enforces the check.
Suggested change
| const assetsToAllocate = to1e18(100) | |
| const minSharesOut = to1e18(100) | |
| const assetsToAllocate = to1e18(100) | |
| const expectedSharesOut = assetsToAllocate | |
| const minSharesOut = expectedSharesOut - 1n |
There was a problem hiding this comment.
It is checked in when allocation is not successful
There was a problem hiding this comment.
We should rename the test name then, to be clear, what scenario we are covering, "when allocation is not successful" feels too general.
- Renamings - Extracted isVaultAuthorized - error change CallerUnauthorized > NotMaintainer
This was referenced Jan 3, 2024
nkuba
reviewed
Jan 3, 2024
nkuba
reviewed
Jan 3, 2024
core/test/Acre.test.ts
Outdated
| describe("updateDispatcher", () => { | ||
| context("when caller is not an owner", () => { | ||
| it("should revert", async () => { | ||
| await expect(acre.connect(staker1).updateDispatcher(ZeroAddress)) |
There was a problem hiding this comment.
We could get one more signer named thirdParty from getUnnamedSigner() function call in the fixture setup and use it here.
Added test to Deployment.test.ts checking the initial state right after the deployment scripts execution.
nkuba
previously approved these changes
Jan 3, 2024
core/test/Dispatcher.test.ts
Outdated
Comment on lines
27
to
32
| let governance: HardhatEthersSigner | ||
| let thirdParty: HardhatEthersSigner | ||
| let maintainer: HardhatEthersSigner | ||
| let vault: TestERC4626 | ||
| let acre: Acre | ||
| let tbtc: TestERC20 |
There was a problem hiding this comment.
Can we move contract vars definition above signers for consistency?
let acre: Acre
let tbtc: TestERC20
let vault: TestERC4626
let governance: HardhatEthersSigner
let thirdParty: HardhatEthersSigner
let maintainer: HardhatEthersSigner
r-czajkowski
reviewed
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.