SIWW auth #724
Merged
SIWW auth #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works as expected. Need to clean up the code and handle errors.
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Move the Acre API requests to separate functions and set the Acre API endpoint via env variables.
We should delete session when the backend returns `address` field and that address is not equal to address returned by connector.
Pass the public key to create the session and update the flow when a user changes the account and connects wallet again - we should delete session (that was created for different account) and ask for a nonce to create a new session for updated bitcoin address.
Use the time util function to set the `expirationTime` in `SignInWithWalletMessage` constructor.
Use defined time values to create session expiration time.
kkosiorowska
previously approved these changes
Sep 13, 2024
We decided to extend the expiration time of the valid session for the dapp to 7 days.
kkosiorowska
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Sign-In With Wallet auth to the Acre dapp. When a user connects the wallet we create a session by sending a request to the Acre API backend. The session is valid for 3 hours.
SIWW flow: