Improve styles for the dApp #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
r-czajkowski
requested changes
Dec 13, 2023
kkosiorowska
force-pushed
the
improve-styles-dapp
branch
from
e09ce8d to
c8d9e39
Compare
Comment on lines
+58
to
+63
| return { | ||
| ...defaultStyles, | ||
| color: "red.400", | ||
| borderColor: "red.400", | ||
| bg: "transparent", | ||
| } |
There was a problem hiding this comment.
Just to make sure - shouldn't we override the _hover (and maybe _active) state?
There was a problem hiding this comment.
You're probably right. But at the moment we don't have a style guide. I left a comment there for us to edit the styles when the guide is ready.
r-czajkowski
previously approved these changes
Dec 14, 2023
r-czajkowski
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been many changes in the designs. This PR updates the styles to the current design. Not everything is fully defined in the style guide yet, but let's keep it up to date. The scope of the changes includes the addition of themes for individual components and minor visual improvements.