Number input component #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkosiorowska
force-pushed
the
custom-input
branch
from
113bf2e to
a26798b
Compare
r-czajkowski
requested changes
Dec 22, 2023
kkosiorowska
commented
Dec 22, 2023
Comment on lines
+123
to
+135
| <Box __css={styles.labelContainer}> | ||
| Amount | ||
| <Box __css={styles.balanceContainer}> | ||
| <Box as="span" __css={styles.balance}> | ||
| Balance | ||
| </Box> | ||
| <CurrencyBalance | ||
| size={size === "lg" ? "md" : "sm"} | ||
| amount={tokenBalance} | ||
| currencyType={currencyType} | ||
| /> | ||
| </Box> | ||
| </Box> |
There was a problem hiding this comment.
@r-czajkowski I still don't quite sure how best to style this part. Let me know if you have any better ideas.
r-czajkowski
approved these changes
Dec 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a custom component for Number input. To display large numbers with decimal separators, it was decided to use the react-number-format library. This library is also used in the Threshold Dashboard. Changes implemented:
NumberFormatInputcomponentAt the moment, the changes only relate to input. Adding the form and using the input will be done later.
As the input has a max button, we need to convert the number very precisely. This is why we use the
fixedPointNumberToStringmethod. The solution is based on the already existing formatting system in Taho.Testing
Let's use a patch file to test. Use the following file: input-tests.patch