Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure prettier.ignorePath for Visual Studio Code #80

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

nkuba
Copy link
Member

@nkuba nkuba commented Dec 18, 2023

In our monorepo we defined seprate prettier configurations for the modules and the root directory. VS Code has problems resolving the prettier ignore configuration, and reads root's file by default, which ignores the modules from formatting.
Here we specify no file to use with prettier ignore configuration so VS Code can still work.

In our monorepo we defined seprate prettier configurations for the
modules and the root directory. VS Code has problems resolving the
prettier ignore configuration, and reads root's file by default, which
ignores the modules from formatting.
Here we specify no file to use with prettier ignore configuration so VS
Code can still work.
Copy link
Contributor

@kkosiorowska kkosiorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work well. 🚀 However, this PR still doesn't solve the eslint issue. Errors aren't underlined from the code level.- video below.

Let's not block this PR and solve this problem in a separate PR.

Screen.Recording.2023-12-18.at.14.11.59.mov

Screenshot 2023-12-18 at 14 15 45

@kkosiorowska kkosiorowska merged commit 236255c into main Dec 18, 2023
9 checks passed
@kkosiorowska kkosiorowska deleted the vscode-prettier branch December 18, 2023 13:25
@nkuba nkuba added the ⚙️ Backend APIs, Maintainers label Dec 22, 2023
@nkuba nkuba self-assigned this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Backend APIs, Maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants