Remove notifications for completed transactions #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need this logic because we have removed the notifications.
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
The code looks good to me, but I'm leaving the final approval + merge to @michalinacienciala .
michalinacienciala
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Tested for the deposit in LL. For withdrawal in the standalone dapp. During testing of withdrawal there was some Gelato error thrown, but it looks inconsequential (funds got returned, withdrawal visible in dapp) and could not be reproduced. I think we can merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes notifications for completed transactions. What has been done:
ActivitiesListandActivitiesListItemcomponents.Alert.latestActivitiesUI
Before
After
