Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate points based on value after subtracting fees #868

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

kkosiorowska
Copy link
Contributor

Closes #867

We are estimating points on the deposit form based on the deposit amount entered by the user. we think the points should be calculated on the value we estimate the deposit will have after fees subtraction (i.e. "You will deposit" amount).

Before
Screenshot 2024-11-15 at 12 28 53

After

Screenshot 2024-11-15 at 12 37 13

We are estimating points on the deposit form based on the deposit amount entered by the user. we think the points should be calculated on the value we estimate the deposit will have after fees subtraction (i.e. "You will deposit" amount).
@kkosiorowska kkosiorowska added this to the Ledger Live Launch milestone Nov 15, 2024
@kkosiorowska kkosiorowska self-assigned this Nov 15, 2024
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for acre-dapp-testnet ready!

Name Link
🔨 Latest commit 25e44f0
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp-testnet/deploys/673c417fcaee470008e2a8be
😎 Deploy Preview https://deploy-preview-868--acre-dapp-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for acre-dapp ready!

Name Link
🔨 Latest commit 25e44f0
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp/deploys/673c417f5a40540008193769
😎 Deploy Preview https://deploy-preview-868--acre-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

r-czajkowski
r-czajkowski previously approved these changes Nov 18, 2024
@michalinacienciala
Copy link
Contributor

Tested on mainnet LL:
image

You will deposit shows 0.139 BTC, points per day show +140. Shouldn't it be +139? Or is it justified by different handling of rounding in the points calculation script and in the You will deposit calculation?

@kkosiorowska
Copy link
Contributor Author

You will deposit shows 0.139 BTC, points per day show +140. Shouldn't it be +139? Or is it justified by different handling of rounding in the points calculation script and in the You will deposit calculation?

Yeah, the difference is rounding. @nkuba how should we round the number? Should the user see the number 140 or 139? Should we round the number of points up or down?

@nkuba
Copy link
Member

nkuba commented Nov 18, 2024

@kkosiorowska Round down, please.

@kkosiorowska
Copy link
Contributor Author

@kkosiorowska Round down, please.

Done - fdd748f

Before
Screenshot 2024-11-18 at 16 25 08

After

Screenshot 2024-11-18 at 16 31 31

@michalinacienciala michalinacienciala merged commit 2125c02 into main Nov 19, 2024
28 checks passed
@michalinacienciala michalinacienciala deleted the fix-estimate-points branch November 19, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should estimate points on the deposit form based on the "You will deposit" amount
4 participants