-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate points based on value after subtracting fees #868
Conversation
We are estimating points on the deposit form based on the deposit amount entered by the user. we think the points should be calculated on the value we estimate the deposit will have after fees subtraction (i.e. "You will deposit" amount).
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Yeah, the difference is rounding. @nkuba how should we round the number? Should the user see the number 140 or 139? Should we round the number of points up or down? |
@kkosiorowska Round down, please. |
Done - fdd748f After |
Closes #867
We are estimating points on the deposit form based on the deposit amount entered by the user. we think the points should be calculated on the value we estimate the deposit will have after fees subtraction (i.e. "You will deposit" amount).
Before
After