Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all needed accounts are connected before staking #88

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

kkosiorowska
Copy link
Contributor

@kkosiorowska kkosiorowska commented Dec 20, 2023

This PR makes sure that all accounts are connected before staking. If the account is not connected, it displays the correct modal. The connection modals aren't part of the staking flow. For this reason, a special SupportWrapper component was created. Let's display additional modals inside this component. Modals which should be rendered inside this component:

  • missing account modal
  • paused flow

UI

Screen.Recording.2023-12-20.at.16.16.24.mov

After clicking on the stake button, if the user has no accounts connected, should see special modals with connection options.
@kkosiorowska kkosiorowska self-assigned this Dec 20, 2023
Base automatically changed from handling-modal-window to main December 20, 2023 14:33
@kkosiorowska kkosiorowska marked this pull request as ready for review December 20, 2023 14:44
Copy link
Contributor

@r-czajkowski r-czajkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@r-czajkowski r-czajkowski merged commit a8514ba into main Dec 21, 2023
9 checks passed
@r-czajkowski r-czajkowski deleted the connect-accounts branch December 21, 2023 10:31
@kkosiorowska kkosiorowska mentioned this pull request Jan 2, 2024
@nkuba nkuba mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants