Update the referral mechanism #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect the referral code in the main router loader instead of the hooks. Using a router loader is simpler and we avoid race between two hooks `useDetectEmbed` and `useDetectReferral`. We noticed a bug with hooks implementation - `acre.referral` set to `0` for Ledger Live after clearing local storage. The `acre.referral` key should always be set to `2083` value for users using Acre in Ledger Live.
r-czajkowski
requested review from
nkuba,
kpyszkowski,
kkosiorowska and
michalinacienciala
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
If there is no `ref` query param in URL. In that case we should back to the default value.
|
Handle a case when someone passes invalid referral code via URL. We should set the default value in local storage instaed of using the previous one.
Accept only numbers in string w/o leading zeros.
kkosiorowska
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #876
Detect the referral code in the main router loader instead of the hooks. Using a router loader is simpler and we avoid race between two hooks
useDetectEmbedanduseDetectReferral.We noticed a bug with hooks implementation -
acre.referralset to0for Ledger Live after clearing local storage. Theacre.referralkey should always be set to2083value for users using Acre in Ledger Live.