Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApp: AcreTVLProgress component mask fix #895

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kpyszkowski
Copy link
Contributor

The AcreTVLProgress component was not responsive looking bad on mobile. This PR fixes it.
The only flaw are bottom rounded corners which are not very rounded on mobile. It's baked into the mask so it scales accordingly to the viewport - the smaller screen is, the smaller is the radius. It's unavoidable. Still looks better than before.

Before:
image

After:
image

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for acre-dapp-testnet ready!

Name Link
🔨 Latest commit 00a85e7
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp-testnet/deploys/6740a8e73e0fe50008551429
😎 Deploy Preview https://deploy-preview-895--acre-dapp-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for acre-dapp ready!

Name Link
🔨 Latest commit 00a85e7
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp/deploys/6740a8e7c58a7100084708c6
😎 Deploy Preview https://deploy-preview-895--acre-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@kkosiorowska kkosiorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested solution on smaller screens and the TVL component doesn't always look good. See below:

Screen.Recording.2024-11-25.at.09.40.23.mov
Screenshot 2024-11-25 at 09 37 13

@kpyszkowski kpyszkowski marked this pull request as draft December 12, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants