Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ConnectWallet component #896

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Conversation

r-czajkowski
Copy link
Contributor

@r-czajkowski r-czajkowski commented Nov 22, 2024

Closes: AENG-35

Implement a mobile version of the ConnectWallet component - display dropdown with options:

  • copy address,
  • swtich account (if this feature is supported by embedded app),
  • disconnect.
Screenshots

Zrzut ekranu 2024-11-22 o 18 49 21
obraz

Implement a mobile version of this component - display dropdown with
options:
- copy address,
- swtich account (if this feature is supported by embedded app),
- disconnect.
Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for acre-dapp ready!

Name Link
🔨 Latest commit 8b499f2
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp/deploys/67471b41af74740008e1176e
😎 Deploy Preview https://deploy-preview-896--acre-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for acre-dapp-testnet ready!

Name Link
🔨 Latest commit 8b499f2
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp-testnet/deploys/67471b41d8fde10008fc5ea2
😎 Deploy Preview https://deploy-preview-896--acre-dapp-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nkuba
nkuba previously approved these changes Nov 26, 2024
Copy link

linear bot commented Nov 26, 2024

Keep the dropdown opene when the user selects `copy address` option.

Extract shared component props to an array to not repeat the code.
Copy link
Contributor

@kkosiorowska kkosiorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkosiorowska kkosiorowska merged commit 1fc5b15 into main Nov 27, 2024
28 checks passed
@kkosiorowska kkosiorowska deleted the fix-connect-wallet-component branch November 27, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants