Add a waitForTransaction to time helpers
#1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beaurancourt
force-pushed
the
wait-for-transaction
branch
from
5f53a57 to
0fb9026
Compare
The [hardhat-ethers](https://github.com/NomicFoundation/hardhat/blob/8f47553a88eb1251907398513449bc15689041d6/packages/hardhat-ethers/src/internal/hardhat-ethers-provider.ts#L362-L368) version is unimplemented, so we provide one.
beaurancourt
force-pushed
the
wait-for-transaction
branch
from
0fb9026 to
c8e5d00
Compare
|
The test package/build failure is
Anyone know what that's about? |
jagodarybacka
approved these changes
Jan 31, 2024
| }) | ||
|
|
||
| it("does not return immediately on non-hardhat networks", async function () { | ||
| this.hre.network.name = "not-hardhat" |
There was a problem hiding this comment.
Out of curiosity how changing network name make this transaction take longer? 😄
There was a problem hiding this comment.
the first big of logic in waitForTransaction is:
if (hre.network.name === "hardhat") {
return true
}The default for tests is "hardhat", so changing it to anything else causes that branch to not run and for it to actually wait (like it would on sepolia or mainnet)
I would check if this is happening in the base repo first before burning time here |
|
The token issue is due to a missing CI token for Valkyrie to handle tagging, pushing, and releasing the package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #2
The hardhat-ethers version is unimplemented, so we provide one.
This is a general purpose wait function, but the inspirational use case is waiting enough blocks after deploying a contract before verifying it on etherscan.
Tagging @pdyraga and @jagodarybacka for review