-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASoC: SOF: Intel: add ArrowLake machines #4541
Conversation
Can one of the admins verify this patch?
|
@@ -0,0 +1,379 @@ | |||
// SPDX-License-Identifier: GPL-2.0-only | |||
/* | |||
* soc-acpi-intel-arl-match.c - tables and support for arl ACPI enumeration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ARL or maybe expand it to ArrowLake
/* | ||
* soc-acpi-intel-arl-match.c - tables and support for arl ACPI enumeration. | ||
* | ||
* Copyright (c) 2022, Intel Corporation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @arunt1 , looks good now. Let's wait for other reviews to complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good but you have a major conflicts with the renamed SOF_INTEL_IPC4 as SOF_IPC_TYPE_4 - compilation is broken.
sound/soc/sof/intel/pci-mtl.c
Outdated
.irqindex_host_ipc = -1, | ||
.chip_info = &mtl_chip_info, | ||
.ipc_supported_mask = BIT(SOF_INTEL_IPC4), | ||
.ipc_default = SOF_INTEL_IPC4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately this conflicts with the renaming added by @ujfalusi with "ASoC: SOF: Intel: Use generic names for IPC types"
So the net result is that this PR will not build and we can't send this upstream - and it will be difficult to apply to stable kernels.
yay renaming.
/* | ||
* soc-apci-intel-arl-match.c - tables and support for ARL ACPI enumeration. | ||
* | ||
* Copyright (c) 2022 Intel Corporation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2023!
also @arunt1 please accept the invite to join the project so that the SOF CI runs without admins having to vouch for you, thank you |
43b9d1c
to
d97bfe9
Compare
Initial support for ARL w/ RT711 Signed-off-by: Arun T <[email protected]>
Split out firmware definitions for Intel Arrow Lake platforms. Signed-off-by: Arun T <[email protected]>
No description provided.