Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASoC: SOF: Intel: add ArrowLake machines #4541

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

arunt1
Copy link

@arunt1 arunt1 commented Aug 23, 2023

No description provided.

@sofci
Copy link
Collaborator

sofci commented Aug 23, 2023

Can one of the admins verify this patch?

reply test this please to run this test once

@kv2019i kv2019i changed the title Sof dev audio ASoC: SOF: Intel: add ArrowLake machines Aug 23, 2023
@@ -0,0 +1,379 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
* soc-acpi-intel-arl-match.c - tables and support for arl ACPI enumeration.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARL or maybe expand it to ArrowLake

/*
* soc-acpi-intel-arl-match.c - tables and support for arl ACPI enumeration.
*
* Copyright (c) 2022, Intel Corporation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2023

include/sound/soc-acpi-intel-match.h Show resolved Hide resolved
sound/soc/sof/intel/pci-mtl.c Outdated Show resolved Hide resolved
kv2019i
kv2019i previously approved these changes Aug 25, 2023
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arunt1 , looks good now. Let's wait for other reviews to complete.

Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good but you have a major conflicts with the renamed SOF_INTEL_IPC4 as SOF_IPC_TYPE_4 - compilation is broken.

.irqindex_host_ipc = -1,
.chip_info = &mtl_chip_info,
.ipc_supported_mask = BIT(SOF_INTEL_IPC4),
.ipc_default = SOF_INTEL_IPC4,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately this conflicts with the renaming added by @ujfalusi with "ASoC: SOF: Intel: Use generic names for IPC types"

So the net result is that this PR will not build and we can't send this upstream - and it will be difficult to apply to stable kernels.

yay renaming.

/*
* soc-apci-intel-arl-match.c - tables and support for ARL ACPI enumeration.
*
* Copyright (c) 2022 Intel Corporation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2023!

@plbossart
Copy link
Member

also @arunt1 please accept the invite to join the project so that the SOF CI runs without admins having to vouch for you, thank you

@plbossart plbossart requested a review from ranj063 August 28, 2023 15:43
@plbossart plbossart merged commit 1af9600 into thesofproject:topic/sof-dev Aug 28, 2023
9 checks passed
Initial support for ARL w/ RT711

Signed-off-by: Arun T <[email protected]>
Split out firmware definitions for Intel Arrow Lake platforms.

Signed-off-by: Arun T <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants