soundwire: stream: check return value #4576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardliao
requested review from
RanderWang,
shumingfan,
oder-chiou,
jack-cy-yu,
ryans-lee and
vijendarmukunda
as code owners
sdw_fill_msg could return error. Signed-off-by: Bard Liao <[email protected]>
RanderWang
reviewed
Sep 7, 2023
| ret = sdw_fill_msg(wr_msg, NULL, addr, 1, SDW_BROADCAST_DEV_NUM, | ||
| SDW_MSG_FLAG_WRITE, wbuf); | ||
| if (ret < 0) | ||
| return ret; |
There was a problem hiding this comment.
will ret > 0 ? no ? why not if (ret) ?
There was a problem hiding this comment.
will ret > 0 ? no ? why not if (ret) ?
ret will never > 0. However, use if (ret < 0) can keep consistent.
There was a problem hiding this comment.
I don't think any error can be returned here given the parameters given.
This is a false positive IMHO.
There was a problem hiding this comment.
I don't think any error can be returned here given the parameters given.
This is a false positive IMHO.
Indeed, let me close the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdw_fill_msg could return error.