ACP 6.3 SOF support and Add ACP SRAM option for Data bin loading #4642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add acpi machine id for ACP6.3 version based platform and configure driver data to enable SOF sound card support on newer boards. Signed-off-by: Vijendar Mukunda <[email protected]>
Add SOF support for ACP6.3 version based platform Signed-off-by: Vijendar Mukunda <[email protected]>
Increase DSP cache window range to 2.5MB to align with ACP memory. Signed-off-by: Vijendar Mukunda <[email protected]>
vijendarmukunda
requested review from
bhiregoudar,
sunilkumardommati,
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao,
ujfalusi,
kuanhsuncheng and
yaochunhung
as code owners
plbossart
reviewed
Oct 17, 2023
| .drv_name = "acp63-dsp", | ||
| .pdata = &acp_quirk_data, | ||
| .fw_filename = "sof-acp_6_3.ri", | ||
| .sof_tplg_filename = "sof-acp_6_3.tplg", |
There was a problem hiding this comment.
nit-pick: the use of _ is inconsistent, you used - everywhere so far.
DSP data bin can be loaded in to ACP DRAM or ACP SRAM. Add conditional check for ACP DRAM usage for data bin loading. Rename DRAM base address macro to have symmetry. Signed-off-by: Vijendar Mukunda <[email protected]>
Provide an option to load DSP data bin to ACP SRAM. Signed-off-by: Vijendar Mukunda <[email protected]>
vijendarmukunda
force-pushed
the
topic/sof-dev
branch
from
9eda0dd to
3b9af79
Compare
plbossart
approved these changes
Oct 18, 2023
bhiregoudar
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series contains changes for adding SOF support for ACP v6.3 and ACP SRAM option to load the Data bin contents.
Pull request for ACP FW changes has been created.
thesofproject/sof#8335