Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMD SOF based generic SoundWire machine driver #5068

Merged
merged 31 commits into from
Jul 5, 2024
Merged

AMD SOF based generic SoundWire machine driver #5068

merged 31 commits into from
Jul 5, 2024

Conversation

vijendarmukunda
Copy link

This patch series is rebase version of PR#5034

plbossart
plbossart reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me @vijendarmukunda

I only have minor comments, time for others to comment as well. @bardliao @charleskeepax on your mark, set, go!

sound/soc/sdw_utils/soc_sdw_rt712_sdca.c Outdated Show resolved Hide resolved
sound/soc/sof/amd/Kconfig Show resolved Hide resolved
sound/soc/amd/acp/soc_amd_sdw_common.h Outdated Show resolved Hide resolved
plbossart
plbossart requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last patch needs a bit more work IMHO, still too much duplication of complicated code that we don't want to fork.

The rest looks ok, thanks!

sound/soc/amd/acp/acp-sdw-sof-mach.c Show resolved Hide resolved
sound/soc/amd/acp/soc_amd_sdw_common.h Outdated Show resolved Hide resolved
sound/soc/amd/acp/acp-sdw-sof-mach.c Outdated Show resolved Hide resolved
sound/soc/amd/acp/acp-sdw-sof-mach.c Show resolved Hide resolved
sound/soc/amd/acp/acp-sdw-sof-mach.c Show resolved Hide resolved
sound/soc/amd/acp/acp-sdw-sof-mach.c Show resolved Hide resolved
sound/soc/amd/acp/acp-sdw-sof-mach.c Outdated Show resolved Hide resolved
sound/soc/amd/acp/acp-sdw-sof-mach.c Outdated Show resolved Hide resolved
sound/soc/amd/acp/acp-sdw-sof-mach.c Show resolved Hide resolved
sound/soc/amd/acp/acp-sdw-sof-mach.c Show resolved Hide resolved
@plbossart
Copy link
Member

SOFCI TEST

@vijendarmukunda
Copy link
Author

vijendarmukunda commented Jun 25, 2024 •
edited
Loading

The last patch needs a bit more work IMHO, still too much duplication of complicated code that we don't want to fork.

The rest looks ok, thanks!

Agreed. We are going to refactor the code . We need to add support for newer ACP variants. We are going to add support for legacy (NO DSP) machine driver support where we are going to refactor existing code.
We would like to implement as an incremental patch series.

@vijendarmukunda
ASoC: intel: rename codec_info and dai_info structures names
3a661c4 
To make it generic, rename structure 'sof_sdw_codec_info' as
'asoc_sdw_codec_info' and 'sof_sdw_dai_info' as 'asoc_sdw_dai_info'.
These structures will be moved to common header file so that it can
be used by other platform machine driver.

Signed-off-by: Vijendar Mukunda <[email protected]>
@vijendarmukunda
ASoC: intel: rename soundwire common header macros
7368b98 
Rename sof quirk macros, dai type and dai link macros with "SOC_SDW" tag.

Signed-off-by: Vijendar Mukunda <[email protected]>
@vijendarmukunda
ASoC: intel: rename soundwire machine driver soc ops
a1e2861 
Rename Soundwire generic machine driver soc ops with tag "asoc".

Signed-off-by: Vijendar Mukunda <[email protected]>
@vijendarmukunda
ASoC: intel: rename soundwire codec helper functions
a90e6f9 
Rename SoundWire codec helper functions with "asoc_sdw" tag.

Signed-off-by: Vijendar Mukunda <[email protected]>
@vijendarmukunda
ASoC: intel: rename maxim codec macros
ae5e49e 
Rename maxim codec part id macros.

Signed-off-by: Vijendar Mukunda <[email protected]>
@vijendarmukunda
ASoC: intel: rename ignore_pch_dmic variable name
954cc8b 
Rename 'ignore_pch_dmic' variable name as 'ignore_internal_dmic'.
This variable will be moved to common header file and will be used by other
platform machine driver code.

Signed-off-by: Vijendar Mukunda <[email protected]>
@vijendarmukunda
ASoC: intel/sdw-utils: move soundwire machine driver soc ops
4fbc325 
Move Intel SoundWire generic machine driver soc ops to common place
so that it can be used by other platform machine driver.

Signed-off-by: Vijendar Mukunda <[email protected]>
@vijendarmukunda
ASoC: intel: move soundwire machine driver common structures
d15fc43 
Move intel generic SoundWire machine driver common structures to
soc_sdw_utils.h file. These structures will be used in other platform
SoundWire machine driver code.

Signed-off-by: Vijendar Mukunda <[email protected]>
@vijendarmukunda
ASoC: intel/sdw_utils: move soundwire machine driver helper functions
f0a24d6 
Move below Intel SoundWire machine driver helper functions to
soc_sdw_utils.c file so that it can be used by other platform machine
driver.
- asoc_sdw_is_unique_device()
- asoc_sdw_get_codec_name()

Signed-off-by: Vijendar Mukunda <[email protected]>
@vijendarmukunda
ASoC: intel/sdw_utils: move dmic codec helper function
565442e 
Move generic dmic codec helper function implementation to
sdw_utils folder so that this function can be used by other platform
machine drivers.

Signed-off-by: Vijendar Mukunda <[email protected]>
@vijendarmukunda
ASoC: intel/sdw_utils: move rtk dmic helper functions
5b8cde7 
Move rtk SoundWire dmic helper functions implementation to sdw_utils
folder to make it generic.

Signed-off-by: Vijendar Mukunda <[email protected]>
@vijendarmukunda
ASoC: intel/sdw_utils: move rt712 sdca helper functions
f07f5a2 
Move RT712 SDCA codec helper file to sdw_utils folder so that these
helper functions can be used by other platform machine drivers.

Signed-off-by: Vijendar Mukunda <[email protected]>
@vijendarmukunda
ASoC: intel/sdw_utils: move rt722 sdca helper functions
7ae6655 
Move RT722 SDCA codec helper file to sdw_utils folder to make it generic.

Signed-off-by: Vijendar Mukunda <[email protected]>
@vijendarmukunda
ASoC: intel: split soundwire machine driver private data
9d227b8 
Split intel generic SoundWire machine driver private data into two
structures. One structure is generic one which can be used by other
platform machine driver and the other one is intel specific one.
Move generic machine driver private data to soc_sdw_utils.h.
Define a void pointer in generic machine driver private data structure
and assign the vendor specific structure in mc_probe() call.

Signed-off-by: Vijendar Mukunda <[email protected]>
@vijendarmukunda
ASoC: intel/sdw_utils: move rt5682 codec helper function
65db629 
Move rt5682 sdw codec helper function to common place holder to make it
generic.

Signed-off-by: Vijendar Mukunda <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel: rename soundwire machine driver soc ops
96990cf 
Rename Soundwire generic machine driver soc ops with tag "asoc".

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel: rename soundwire codec helper functions
bd5838c 
Rename SoundWire codec helper functions with "asoc_sdw" tag.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel: rename maxim codec macros
a2b5ec0 
Rename maxim codec part id macros.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel: rename ignore_pch_dmic variable name
b1f7cbf 
Rename 'ignore_pch_dmic' variable name as 'ignore_internal_dmic'.
This variable will be moved to common header file and will be used by other
platform machine driver code.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw-utils: move soundwire machine driver soc ops
d39388e 
Move Intel SoundWire generic machine driver soc ops to common place
so that it can be used by other platform machine driver.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel: move soundwire machine driver common structures
7361913 
Move intel generic SoundWire machine driver common structures to
soc_sdw_utils.h file. These structures will be used in other platform
SoundWire machine driver code.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: move soundwire machine driver helper functions
941d693 
Move below Intel SoundWire machine driver helper functions to
soc_sdw_utils.c file so that it can be used by other platform machine
driver.
- asoc_sdw_is_unique_device()
- asoc_sdw_get_codec_name()

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: move dmic codec helper function
4776d0c 
Move generic dmic codec helper function implementation to
sdw_utils folder so that this function can be used by other platform
machine drivers.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: move rtk dmic helper functions
a9831fd 
Move rtk SoundWire dmic helper functions implementation to sdw_utils
folder to make it generic.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: move rt712 sdca helper functions
09c60bc 
Move RT712 SDCA codec helper file to sdw_utils folder so that these
helper functions can be used by other platform machine drivers.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: move rt722 sdca helper functions
89b3456 
Move RT722 SDCA codec helper file to sdw_utils folder to make it generic.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel: split soundwire machine driver private data
4f54856 
Split intel generic SoundWire machine driver private data into two
structures. One structure is generic one which can be used by other
platform machine driver and the other one is intel specific one.
Move generic machine driver private data to soc_sdw_utils.h.
Define a void pointer in generic machine driver private data structure
and assign the vendor specific structure in mc_probe() call.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: move rt5682 codec helper function
139e177 
Move rt5682 sdw codec helper function to common place holder to make it
generic.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: move rtk jack common helper functions
da5b183 
Move RTK codec jack common helper functions to common place holder
(sdw_utils folder) to make it generic so that it will be used by
other platform machine driver code.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: move rt700 and rt711 codec helper functions
8e84fd2 
Move RT700 and RT711 Soundwire codec helper functions to common
place holder so that it can be used by other platform machine driver.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: move rtk amp codec helper functions
ccc96ae 
Move RTK amp codec helper functions related implementation to common
place holder to make it generic so that these helper functions will be
used by other platform machine driver modules.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: move cirrus soundwire codec helper functions
5fa4662 
To make it generic, move Cirrus Soundwire codec helper functions to
common place holder so that it can be used by other platform machine
driver.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: move maxim codec helper functions
051b7cb 
Move maxim codec helper functions to common place holder so that
it can be used by other platform machine driver.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: move dai id common macros
8f87e29 
Move dai id common macros from intel SoundWire generic driver to
soc_sdw_utils.h file so that it can be used by other platform machine
driver.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: move soundwire dai type macros
6e7af1f 
Move SoundWire dai type macros to common header file(soc_sdw_util.h).
So that these macros will be used by other platform machine driver.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: move soundwire codec_info_list structure
e377c94 
SoundWire 'codec_info_list' structure is not a platform specific one.
Move codec_info_list structure to common file soc_sdw_utils.c.
Move codec helper functions which uses codec_info_list structure to common
place holder and rename the function by adding _sdw tag. This will allow
to use 'codec_info_list' structure and it's helper functions in other
platform machine driver.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: move machine driver dai link helper functions
778dcb0 
Move machine driver dai link helper functions to common place holder,
So that it can be used by other platform machine driver.
Rename these functions with "asoc_sdw" tag as a prefix.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: sdw_utils: refactor sof_sdw_card_late_probe function
5bd414c 
Refactor sof_sdw_card_late_probe() function and derive a generic
function soc_sdw_card_late_probe() function which can be used by
SoundWire generic machine driver.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: intel/sdw_utils: refactor init_dai_link() and init_simple_dai_l…
59f8b62 
…ink()

To make it generic, refactor existing implementation for
init_dai_link() and init_simple_dai_link() as mentioned below.
- Move init_dai_link() and init_simple_dai_link() to common place holder
- Rename the functions with "asoc_sdw" as prefix.
- Pass the platform specific 'platform_component' structure and its size as
arguments for init_simple_dai_link() function and allocate one more
extra dlc for platform component.
- Pass the 'platform_component' and 'num_platforms' as arguments for
init_dai_link().

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: soc-acpi: add pci revision id field in mach params structure
0b8f009 
Few IP's may have same PCI vendor id and device id and
different revision id. Add revision id field to the
'snd_soc_acpi_mach_params' so that using this field platform
specific implementation can be added in machine driver.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: amd: acp: add soundwire machines for acp6.3 based platform
57677cc 
Add Soundwire machines for acp6.3 based platform.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: SOF: amd: add alternate machines for acp6.3 based platform
15049b6 
Add SoundWire machines as alternate machines for acp6.3 based platform.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: SOF: amd: update mach params subsystem_rev variable
b7cdb4a 
Add pci_rev variable in acp sof driver private data structure and assign
this value to mach_params structure subsystem_rev variable.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@vijendarmukunda @broonie
ASoC: amd/sdw_utils: add sof based soundwire generic machine driver
cb8ea62 
Add sof based Soundwire generic driver for amd platforms.
Currently support added for ACP6.3 based platforms.

Link: thesofproject#5068
Signed-off-by: Vijendar Mukunda <[email protected]>
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
roxell pushed a commit to roxell/linux that referenced this pull request Aug 5, 2024
@broonie
AMD SOF based generic SoundWire machine driver
bb2bf85 
Merge series from Vijendar Mukunda <[email protected]>:

This patch series majorly consists of below changes.
- Rename structures, macros and codec helper names used in Intel
SoundWire generic driver to make it generic.
- Move Intel SoundWire driver common structures, macros and codec
helper functions to common placeholder so that it can be used by
other platform machine driver.
- Refactor few SoundWire common codec helper functions.
- AMD SOF based generic SoundWire machine driver for ACP 6.3 variant.

This work started a couple of months ago to avoid duplication of code
that wasn't really Intel-specific in the "sof_sdw" machine driver.
The code went through multiple iterations, was tested for multiple weeks
and a couple of build issues reported by the Intel kbuild bots were
corrected.

This is the initial version of SoundWire machine driver for AMD
platforms. Additional code refactoring will be done in the next step on
the AMD side.

Link: thesofproject#5068
Reviewed-by: Bard Liao <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbossart plbossart plbossart approved these changes

@charleskeepax charleskeepax charleskeepax left review comments

@bhiregoudar bhiregoudar bhiregoudar approved these changes

@bardliao bardliao bardliao approved these changes

@lgirdwood lgirdwood Awaiting requested review from lgirdwood lgirdwood is a code owner

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

@kv2019i kv2019i Awaiting requested review from kv2019i kv2019i is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@ujfalusi ujfalusi Awaiting requested review from ujfalusi ujfalusi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vijendarmukunda @plbossart @perexg @charleskeepax @bardliao @bhiregoudar