case-lib/lib.sh: use sudo to access debugfs files #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
reviewed
Apr 9, 2024
case-lib/lib.sh
Outdated
| @@ -831,7 +831,7 @@ is_ipc4() | |||
| fi | |||
|
|
|||
| dlogw "using pre kernel 6.9 backwards-compatible fallback with ipc_type kernel parameter" | |||
| if ipc_type=$(cat /sys/module/snd_sof_pci/parameters/ipc_type); then | |||
| if ipc_type=$(sudo cat /sys/module/snd_sof_pci/parameters/ipc_type); then | |||
There was a problem hiding this comment.
This does not seem required. When running sof_insert/sof_remove I noticed sudo can be pretty slow, even slower on Fedora I think. Of course we should ideally cache the result of is_ipc4() but right now we don't.
EDIT: also, sudo creates a lot of journalctl noise already.
plbossart
force-pushed
the
fix/ipc4-fixes
branch
from
6a415f8 to
a07333d
Compare
marc-hb
previously approved these changes
Apr 10, 2024
|
@plbossart want to keep this a draft still? If not then please merge |
|
I missed one: |
Apparently debugfs requires more care. Oh well. Link: thesofproject#1171 Signed-off-by: Pierre-Louis Bossart <[email protected]>
plbossart
force-pushed
the
fix/ipc4-fixes
branch
from
a07333d to
60b9fd4
Compare
marc-hb
approved these changes
Apr 10, 2024
kv2019i
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently debugfs requires more care. Oh well.
Link: #1171