verify-kernel-boot-log.sh hotfix: do not override EXIT handler! #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes commit 7c2ede0 ("Explicitly invoke start_test() in every test-case/*.sh") which already did the TODO but _without_ removing _start_test(). We want one or the other, not a strange and unpredictable mix of both! A future commit will actually replace `start_test()`. Signed-off-by: Marc Herbert <[email protected]>
|
Among others, this gets rid of this error message in the test running immediately after verify-kernel-boot-log.sh: |
|
Jenkins failed to notify Github (internal issue 563) but test results are actually published and they look great: https://sof-ci.01.org/softestpr/PR1189/build390/devicetest/index.html |
|
Much worse, WITHOUT this hotfix, all kernel logs in verify-kernel-boot-log are MISSING! |
marc-hb
added
type:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes commit 7c2ede0 ("Explicitly invoke start_test() in every test-case/*.sh") which already did the TODO but without removing _start_test(). We want one or the other, not a strange and unpredictable mix of both!
A future commit will actually replace
start_test().