Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: tplgtool2: Fix array size calculation for enum values #1230

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

ranj063
Copy link
Contributor

@ranj063 ranj063 commented Sep 7, 2024

Convert the computed value to integer to set the values array size for parsing the enum controls properly.

@ranj063 ranj063 requested a review from a team as a code owner September 7, 2024 01:51
@ranj063 ranj063 requested review from marc-hb and singalsu September 7, 2024 01:52
tools/tplgtool2.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW I'm really curious what construct was doing with this float... if not converting it to an int then what else? This sounds like a bug in construct, it should probably provide a better message

https://sof-ci.01.org/sofpr/PR9441/build7682/devicetest/index.html?model=MTLP_RVP_HDA&testcase=verify-tplg-binary

Copy link
Contributor

@singalsu singalsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked to fix the issue, thanks!

Compute the max name length in terms of number of int32's and use that
set the values array size for parsing the enum controls properly.

Signed-off-by: Ranjani Sridharan <[email protected]>
@ranj063 ranj063 requested a review from marc-hb September 9, 2024 15:58
@marc-hb
Copy link
Collaborator

marc-hb commented Sep 9, 2024

Usual LNL failures in https://sof-ci.01.org/softestpr/PR1230/build738/devicetest/index.html, everything else green.

@marc-hb marc-hb merged commit 172d5a1 into thesofproject:main Sep 9, 2024
6 of 7 checks passed
@ranj063 ranj063 deleted the fix/enum_control branch September 9, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants