Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topology1: adl-max98360a-da7219: support DA7219 headphone codec #8103

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

brentlu
Copy link
Contributor

@brentlu brentlu commented Aug 28, 2023

Add an new topology adl-max98360a-da7219.tplg for DA7219 headphone codec with MAX98360A speaker amplifier on ADL boards. The MCLK frequency is set to 24.576MHz to use PLL bypass mode and avoid the WCLK locking problem on earlier platforms.

Add an new topology adl-max98360a-da7219.tplg for DA7219 headphone
codec with MAX98360A speaker amplifier on ADL boards. The MCLK
frequency is set to 24.576MHz to use PLL bypass mode and avoid the
WCLK locking problem on earlier platforms.

Signed-off-by: Brent Lu <[email protected]>
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brentlu does this mean we no longer need the BCLK early start ? i.e. SSP_CC_BCLK_ES

@brentlu
Copy link
Contributor Author

brentlu commented Aug 28, 2023

@brentlu does this mean we no longer need the BCLK early start ? i.e. SSP_CC_BCLK_ES

Nope. I'm afraid we need explicit clock control from Linux side to remove those clock quirks...

If you are talking about the DA7219, it's using MCLK as clock source so it doesn't need this flag.

@brentlu
Copy link
Contributor Author

brentlu commented Aug 29, 2023

Kernel PR: thesofproject/linux#4542

@brentlu brentlu marked this pull request as ready for review August 29, 2023 02:58
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once merged, please backport to stable-v2.2.

@lgirdwood lgirdwood merged commit dca9085 into thesofproject:main Aug 30, 2023
36 of 41 checks passed
@brentlu brentlu added chrome Chromebooks or ChromeOS ADL Applies to Alder Lake platform labels Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADL Applies to Alder Lake platform chrome Chromebooks or ChromeOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants