[TEST] Volume LLEXT #9172
Closed
[TEST] Volume LLEXT #9172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyakh
force-pushed
the
volume-llext
branch
2 times, most recently
from
17ef624 to
08fe313
Compare
lyakh
force-pushed
the
volume-llext
branch
8 times, most recently
from
1ba6f0c to
a46063c
Compare
|
Zephyr LLEXT regression caused by zephyrproject-rtos/zephyr#73949 lead to https://sof-ci.01.org/sofpr/PR9172/build5783/devicetest/index.html?model=MTLP_RVP_HDA&testcase=check-playback-10sec |
lyakh
force-pushed
the
volume-llext
branch
4 times, most recently
from
99fb71e to
3b69e3c
Compare
Under windows the Python interpreter has to be called explicitly. Without it an attempt to execute a Python script fails silently. Signed-off-by: Guennadi Liakhovetski <[email protected]>
When ipc4_get_drv() fails to find a driver, it might mean, that the driver needs to be linked dynamically. Printing an error in such a case wrongly fails CI testing. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Use consistent TABs and spaces in src/samples/audio/Kconfig Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add a Kconfig option that can be used to flip all LLEXT-supporting code to a modular build. Use that global flag for smart-amp-test, mixin-mixout and eq-iir. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Enable CONFIG_LIBRARY_DEFAULT_MODULAR for MTL to build all supporting code as LLEXT modules. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Maximum instance count cannot be zero, they have to be supplied by respective modules. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Use maximum instance count from modules when building a manifest. Signed-off-by: Guennadi Liakhovetski <[email protected]>
If logging state is cleared while the logging task is still running, it can lead to an inconsistent state. Stop the logging task before clearing the state. Signed-off-by: Guennadi Liakhovetski <[email protected]>
When pipelines are destroyed, component drivers' .reset() and .free() are called. If those drivers were loaded dynamically their memory is then unmapped. But logging takes place in a low priority task, so it is important that no logging is done from those methods. Signed-off-by: Guennadi Liakhovetski <[email protected]>
LNL modules overlay is missing eq_iir and mixin_mixout entries, add them there. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Currently LLEXT module starting addresses are hard-coded in their respective CMakeLists.txt files. This is very wasteful, since it's unknown in what order modules are loaded, inflexible and not easily extendible to other platforms. Switch to calculating addresses automatically based on a single per-platform Kconfig value. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Build src as a loadable llext module. Signed-off-by: Guennadi Liakhovetski <[email protected]>
To make volume an LLEXT module it should have a single TOML configuration file named volume.toml. This is easy to do, using respective Kconfig options. Signed-off-by: Guennadi Liakhovetski <[email protected]>
When building volume as an LLEXT module, two more symbols are required: __divdi3() and module_set_configuration(), export them. Signed-off-by: Guennadi Liakhovetski <[email protected]>
This makes it possible to build volume as an LLEXT module to be loaded at run-time. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add support for LLEXT building to eq-fir. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add support for LLEXT building to asrc. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Add support for LLEXT building to drc. Since multiband DRC calls functions from DRC, we cannot so far build it if DRC is configured as a module. In the future it should be possible to build both as modules and to export symbols between them. Signed-off-by: Guennadi Liakhovetski <[email protected]>
When built as an llext module, eq_fir requires several base-firmware provided symbols, export them. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Export missing symbols for modular DRC builds and select it as a module on MTL and LNL. DRC isn't built by default, so we cannot use CONFIG_LIBRARY_DEFAULT_MODULAR for it. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Test Zephyr PR 74568 which fixed a recent breakage. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Disabling CONFIG_KCPS_DYNAMIC_CLOCK_CONTROL appears to fix speaker-test failures with LLEXT. Signed-off-by: Guennadi Liakhovetski <[email protected]>
MOD_INIT_INSTANCE IPCs can be processed on different cores, different cores can use the same modules. Make shared data uncached. Signed-off-by: Guennadi Liakhovetski <[email protected]>
|
superseded by multiple other PRs e.g. #9453 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this includes #9151 and depends on not yet merged Tephyr PRs, collected as a test in zephyrproject-rtos/zephyr#73274