library_manager: add missing "depends on CONFIG_LLEXT" #9222
Conversation
Block the possibility of compiling library_manager without CONFIG_LLEXT, which obviously fails with dozens of linker errors. PS: I have no idea why library_manager depends on IPC_MAJOR_4. Kconfig is designed to express actual code dependencies, not "supported" configurations. Signed-off-by: Marc Herbert <[email protected]>
marc-hb
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
|
Loadable modules tests failed in https://sof-ci.01.org/sof-pr-viewer/#/build/PR9222/build14036351 so this requires more investigation. |
|
which build target it is affecting? Loadable modules are feature supported from mtl and up. |
| @@ -7,6 +7,7 @@ menu "Library Manager" | |||
| config LIBRARY_MANAGER | |||
| bool "Library Manager Support" | |||
| default n | |||
| depends on CONFIG_LLEXT | |||
There was a problem hiding this comment.
I don't think this is correct. The library manager can also be used for LMDK and IADK modules, which don't need LLEXT
There was a problem hiding this comment.
It was even more incorrect because it should have been:
| depends on CONFIG_LLEXT | |
| depends on LLEXT |
|
I see a related Kconfig fix in #9199, so maybe that helped. Will try again.
This does not matter. See commit message:
There is at least one, non-Intel configuration with Zephyr+IPC3 right now. I doubt it will ever want to use LLEXT but it is not Kconfig's job to stop that and it should be possible to try as long as there's no incompatibility at the code level. Kconfig is not a project management tool or bug tracking tool. https://docs.zephyrproject.org/latest/build/dts/dt-vs-kconfig.html |
|
No time to get to the bottom of this. Just filed more generic: |
Block the possibility of compiling library_manager without CONFIG_LLEXT, which obviously fails with dozens of linker errors.
PS: I have no idea why library_manager depends on IPC_MAJOR_4. Kconfig is designed to express actual code dependencies, not "supported" configurations.