app: boards: intel_adsp_ace15_mtpm: disable mock components #9410
Conversation
Disable CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING. This was enabled with a mock implementation, which is useful for debug, but should not be part of upstream SOF releases for these boards. Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
kv2019i
requested review from
cujomalainey,
abonislawski,
marc-hb and
marcinszkudlinski
|
A reference to where and when @marcinszkudlinski added this cannot hurt. From #9404
|
|
@wszypelt good for you or do you need the mocks for testing reasons ? |
|
@lgirdwood @wszypelt @marcinszkudlinski It seems quickbuild is testing the RTC mock, so the failure is real. @marcinszkudlinski @wszypelt Is this still required or do we have other coverage for DP scheduling? |
|
Testing the RTC mock is fine: it just shouldn't be done with the default, sof-bin release .config. This should be done with some extra This is another, good example of: |
Even if we have other DP usage in tests, I recommend keeping the Google AEC Mock testing in CI. Google is the biggest user of SOF, so keeping the Google's components alive at all times is important. |
Which "CI"? There are different test suites run in very different environments with different configurations. With the current lack of validation leadership, developers have to take an interest in what these various environments are, they unfortunately cannot just say "please someone test my code" and walk away. Otherwise we end up in situations like #9386 and worse. |
|
The mock is used to test DP scheduling and this is only coverage in PR CI currently, so we need to keep it until there is other ways to cover this functionality. |
CONFIG_COMP_STUBS=y was enabled in thesofproject#8722 / commit 8e34109 ("AEC: Enable Google AEC with Mock compliation"). CONFIG_COMP_STUBS indirectly enables CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK which was the desired effect. However it also automatically and silently "mocks" all other 3rd party modules which is not desirable. So, replace it with the more focused `CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK`. `src/audio/Kconfig` says "CONFIG_STUBS: This should only be used in testing environments like fuzzers or CI." Official sof-bin releases include `google_rtc_audio_processing_mock.c` because the CI that uses it can't use extra CONFIGS. That's another topic for another day, see thesofproject#9410. build-mtl/zephyr.strip is identical before versus after this commit. Signed-off-by: Marc Herbert <[email protected]>
CONFIG_COMP_STUBS=y was enabled in #8722 / commit 8e34109 ("AEC: Enable Google AEC with Mock compliation"). CONFIG_COMP_STUBS indirectly enables CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK which was the desired effect. However it also automatically and silently "mocks" all other 3rd party modules which is not desirable. So, replace it with the more focused `CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK`. `src/audio/Kconfig` says "CONFIG_STUBS: This should only be used in testing environments like fuzzers or CI." Official sof-bin releases include `google_rtc_audio_processing_mock.c` because the CI that uses it can't use extra CONFIGS. That's another topic for another day, see #9410. build-mtl/zephyr.strip is identical before versus after this commit. Signed-off-by: Marc Herbert <[email protected]>
Disable CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING. This was enabled with a mock implementation, which is useful for debug, but should not be part of upstream SOF releases for these boards.
Alternative to #9404