Tools: Testbench: Fix IPC4 PGA controls load #9591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranj063
approved these changes
Oct 17, 2024
kv2019i
approved these changes
Oct 17, 2024
singalsu
force-pushed
the
testbench4_pga_load_fix
branch
from
f1494c2
to
8590f58
Compare
|
I fixed the commit text duplicated word "number number", no other changes. |
lgirdwood
approved these changes
Oct 18, 2024
tmleman
approved these changes
Oct 21, 2024
|
@lgirdwood Internal Intel CI, everything's fine. |
|
@singalsu Can you rebase, it seems rebase-and-merge won't work anymore, this is now 22 patches behind mainline and some of your other testbench patches are conflicting. |
This mistake causes the module id and instance number to be garbage, so the control can't be set up later in widget setup. The issue fixes the valgrind step fail with new proposed IPC4 version of scripts/host-testbench.sh. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
force-pushed
the
testbench4_pga_load_fix
branch
from
8590f58
to
0e2bd16
Compare
lgirdwood
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mistake causes the module id and instance number number to be garbage, so the control can't be set up later in widget setup. The issue fixes the valgrind step fail with new proposed IPC4 version of scripts/host-testbench.sh.