Audio: Aria: Fix compilation for HiFi5 #9605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In aria_hifi5.c - The needed type for "in" in AE_LA32X2X2_IP() needs to be ae_int32x4. The HiFi5 code was likely developed with an earlier toolchain that used different type. - Removed unused declared variables, warnings are errors in testbench build. - Changed index_tab to common sof_aria_index_tab[] In aria_generic.c, hifi3 changed INDEX_TAB[] to a common sof_aria_index_tab[]. It avoids link error in HiFi5 build where aria.c is missing the INDEX_TAB[]. The sof_aria_index_tab[] is changed from uint8_t to int32_t type to use the same table in every build. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
|
Changed to non-draft. I don't have good tests for Aria, but I was able to verify that before this change testbench MTL build output with topology sof-hda-benchmark-generic.tplg (copier - gain - mixin - mixout - aria - gain - mixin - mixout - copier) is bit exact with after change MTL build. With after changes build for TGL, MTL, PTL, and no-name HiFi5 platform they are all bit exact. |
lgirdwood
approved these changes
Oct 23, 2024
kv2019i
approved these changes
Oct 23, 2024
|
SOFCI TEST |
abonislawski
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In aria_hifi5.c
In aria_generic.c, hifi3 changed INDEX_TAB[] to a common sof_aria_index_tab[]. It avoids link error in HiFi5 build where aria.c is missing the INDEX_TAB[].
The sof_aria_index_tab[] is changed from uint8_t to int32_t type to use the same table in every build.