Simplify the command line for plugin #9610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for simplifying the command line for the plugin, add an option to use the hw_params when the config name is not specified in the command line to configure the endpoint. Signed-off-by: Ranjani Sridharan <[email protected]>
When choosing the audio format during prepare, use the hw_params for matching against the available topology formats. This is in preparation to simplify the command line for the plugin to drop the config name. Signed-off-by: Ranjani Sridharan <[email protected]>
Make the card/dev names and config names optional in the command line. This will simplify the command line to just pass the PCM ID to start playback using the default device as follows: aplay -Dsof:plugin:1 Signed-off-by: Ranjani Sridharan <[email protected]>
ranj063
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
lgirdwood
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.