app: board: Add define CONFIG_COUNTER #9636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbernatxintel
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
lgirdwood
approved these changes
Nov 4, 2024
kv2019i
requested changes
Nov 4, 2024
| @@ -43,6 +43,7 @@ CONFIG_SOF_LOG_LEVEL_INF=y | |||
| CONFIG_ZEPHYR_LOG=y | |||
There was a problem hiding this comment.
you can use: "app: intel_adsp_ace30_ptl.conf: enable CONFIG_COUNTER" prefix.
Also in commit, I think it's also to mention the test case (even if it's not a public test), but I'd also add a brief sentence CONFIG_COUNTER is required for implementation of basefw_get_ext_system_time(). This makes it easily to look up which piece of code this affects.
There was a problem hiding this comment.
Thank you for your comment, I have corrected the commit title and commit message, regarding the test it has no test cases. It is simply such a test and does not take parameters
tmleman
approved these changes
Nov 5, 2024
A new definition has been added, which is crucial for the proper execution of the test test_102_08_extended_time_check. This definition ensures the correct operation of the basefw_get_ext_system_time() function. Signed-off-by: Grzegorz Bernat <[email protected]>
gbernatxintel
force-pushed
the
gb_ptl_extended_time_check
branch
from
5446c44
to
d38f41b
Compare
kv2019i
approved these changes
Nov 13, 2024
lgirdwood
approved these changes
Nov 13, 2024
|
SOFCI TEST |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A definition has been added which is essential
to work properly the test test_102_08_extended_time_check.