Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topology2: add 96KHz rate support for SDW jack #9642

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Topology2: add 96KHz rate support for SDW jack #9642

merged 1 commit into from
Nov 7, 2024

Conversation

bardliao
Copy link
Collaborator

@bardliao bardliao commented Nov 6, 2024

Add 96KHz rate support for SoundWire jack device.

@bardliao bardliao requested a review from jsarha as a code owner November 6, 2024 12:04
@kv2019i kv2019i requested a review from singalsu November 6, 2024 19:13
kv2019i
kv2019i approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok although it's not quite common to not have any users yet in the tree. adding @singalsu to check the usage. This will have to use SRC or otherwise will be of limited use towards user-space.

@bardliao bardliao marked this pull request as draft November 7, 2024 05:57
@bardliao
Topology2: add more rates support for SDW jack
c6a1494 
Add 96KHz/192KHz rates support for SoundWire jack device.

Signed-off-by: Bard Liao <[email protected]>
@bardliao bardliao marked this pull request as ready for review November 7, 2024 06:18
@bardliao
Copy link
Collaborator Author

bardliao commented Nov 7, 2024

Looks ok although it's not quite common to not have any users yet in the tree. adding @singalsu to check the usage. This will have to use SRC or otherwise will be of limited use towards user-space.

As far as I know, we always expose single sample rate to user space. Not sure if SRC is necessary, I set the same rate to all elements in the entire path.

@lgirdwood
Copy link
Member

Looks ok although it's not quite common to not have any users yet in the tree. adding @singalsu to check the usage. This will have to use SRC or otherwise will be of limited use towards user-space.

As far as I know, we always expose single sample rate to user space. Not sure if SRC is necessary, I set the same rate to all elements in the entire path.

1st step is to enable the interface at the new rates so that aplay can directly use the new rates. 2nd step is SRC etc.

@lgirdwood lgirdwood merged commit b372425 into thesofproject:main Nov 7, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kv2019i kv2019i kv2019i approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

@jsarha jsarha Awaiting requested review from jsarha jsarha is a code owner

@singalsu singalsu Awaiting requested review from singalsu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bardliao @lgirdwood @kv2019i