zephyr: lib/dma.h: limit use of platform/lib/dma.h #9667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kv2019i
requested review from
lyakh,
iuliana-prodan,
dbaluta,
abonislawski,
lgirdwood,
plbossart,
mmaka1 and
lbetlej
as code owners
26 tasks
lgirdwood
approved these changes
Nov 19, 2024
tmleman
approved these changes
Nov 19, 2024
lyakh
approved these changes
Nov 20, 2024
| select XT_INTERRUPT_LEVEL_5 | ||
| select INTEL_MN | ||
| select WAKEUP_HOOK | ||
| select SCHEDULE_DMA_SINGLE_CHANNEL |
There was a problem hiding this comment.
nice! Can some of these be removed completely? E.g. INTEL_MN looks Intel-specific, and we don't do XTOS builds on "main" any more?
There was a problem hiding this comment.
Others are removed, but INTEL_MN seems to have more complex baggage still in place. I'm afraid the Zephyr SSP driver depends on this (still)... needs to be cleaned up before this can be merged.
There was a problem hiding this comment.
@lyakh ok, now filed zephyrproject-rtos/zephyr#81734 for Zephyr and will submit a separate PR for SOF for this. I'll update this series to still keep INTEL_MN.
|
Hmm, ok, there's a failure on imx8m that I missed: https://github.com/thesofproject/sof/actions/runs/11914362596/job/33202110141?pr=9667 |
lgirdwood
changed the title
kv2019i
force-pushed
the
202411-plat-remove-lib-dma-h
branch
from
fae13c5
to
e5a2d68
Compare
|
V2:
|
Remove unused Kconfig dependencies for CONFIG_CAVS. These were valid entries for XTOS builds, but as CAVS no longer has any XTOS suppot in the tree, these can be now removed. Equivalent settings are now moved all to Zephyr. Signed-off-by: Kai Vehmanen <[email protected]>
The platform lib/dma.h definitions are only needed in a small set of usages. Make the inclusion conditional and add a note to guide new configurations to use CONFIG_DMA_DOMAIN instead. Signed-off-by: Kai Vehmanen <[email protected]>
The platform lib/dma.h is no longer needed in SOF Zephyr builds unless the legacy DMA domain scheduler is used. This is not the case for any Intel target, so the lib/dma.h headers can be removed. Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
force-pushed
the
202411-plat-remove-lib-dma-h
branch
from
e5a2d68
to
eb516a9
Compare
|
V3:
|
kv2019i
changed the title
lgirdwood
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot remove platform/lib/dma.h completely, but limit its use and make it optional for new targets.
Link: #5794