platform: intel: ace: remove all unnecessary clk.h definitions #9683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kv2019i
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
lyakh
reviewed
Nov 27, 2024
| /** \brief Total number of clocks */ | ||
| #define NUM_CLOCKS (CLK_SSP + 1) | ||
| #define NUM_CLOCKS NUM_CPU_FREQ |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks @lyakh , this was a good catch. This is mixing number of clocks and number of frequencies (each CPU clock has). Fixed version uploaded now.
Strip all unnecessary definitions from Intel ACE clk.h platform code. Only expose the main DSP clock via the SOF clk.h layer, as required by cpu-clk-manager.c. Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
force-pushed
the
202411-clk-prune-ace-plat-code
branch
from
5389b25 to
d721f76
Compare
kv2019i
requested review from
iuliana-prodan and
abonislawski
as code owners
Add a build assert to ensure platform NUM_CLOCKS is set to at least CONFIG_CORE_COUNT. This is assumed to hold in the implementation of platform_clock_init(). Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
force-pushed
the
202411-clk-prune-ace-plat-code
branch
from
d721f76 to
92a3c29
Compare
lgirdwood
approved these changes
Nov 28, 2024
lyakh
approved these changes
Dec 2, 2024
abonislawski
approved these changes
Dec 4, 2024
tmleman
approved these changes
Dec 4, 2024
|
SOFCI TEST |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strip all unnecessary definitions from Intel ACE clk.h platform code. Only expose the main DSP clock via the SOF clk.h layer, as required by cpu-clk-manager.c.