Tools: Topology2: Add pre-processing to ACE 1/2/3.x PCM DMIC topologies #9690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The topologies for PCs those have PCH DMIC enabled have too silent noteboook lid microphones capture level. It can be improved with enable of DRC and beamformer TDFB components in topologies build. Since the same pipelines are not used for other microphone endpoints, it is safe to apply fixed processing configuration. The topologies with -2ch are set with DRC profile "dmic_default" and with TDFB profile "line2_generic_pm10deg". It provides about +10 dB boost to sound level and a user facing microphone stereo beam that improves signal-to-noise ratio. The user space controls are disabled by default, so the user needs to set the features on with alsamixer or amixer conmmands. The 4ch topologies are set with passthrough blob for beamformer. With a lot of variation in array form factors there is no generic setting available. The DRC setting is the same for 4ch and provides +10 dB boost. The impacted topologies are: - sof-mtl-rt711-4ch - sof-mtl-rt711-l0-rt1316-l3-4ch - sof-mtl-rt711-l0-rt1316-l3-2ch - sof-mtl-rt712-l0-4ch - sof-mtl-rt712-l0-2ch Signed-off-by: Seppo Ingalsuo <[email protected]>
The topologies for PCs those have PCH DMIC enabled have too silent noteboook lid microphones capture level. It can be improved with enable of DRC and beamformer TDFB components in topologies build. Since the same pipelines are not used for other microphone endpoints, it is safe to apply fixed processing configuration. The topologies with -2ch are set with DRC profile "dmic_default" and with TDFB profile "line2_generic_pm10deg". It provides about +10 dB boost to sound level and a user facing microphone stereo beam that improves signal-to-noise ratio. The user space controls are disabled by default, so the user needs to set the features on with alsamixer or amixer conmmands. The 4ch topologies are set with passthrough blob for beamformer. With a lot of variation in array form factors there is no generic setting available. The DRC setting is the same for 4ch and provides +10 dB boost. The impacted topologies are: - sof-lnl-rt711-4ch - sof-lnl-rt713-l0-rt1318-l1-2ch - sof-lnl-cs42l43-l0-4ch - sof-lnl-cs42l43-l0-cs35l56-l3-2ch Signed-off-by: Seppo Ingalsuo <[email protected]>
The topologies for PCs those have PCH DMIC enabled have too silent noteboook lid microphones capture level. It can be improved with enable of DRC and beamformer TDFB components in topologies build. Since the same pipelines are not used for other microphone endpoints, it is safe to apply fixed processing configuration. The topologies with -2ch are set with DRC profile "dmic_default" and with TDFB profile "line2_generic_pm10deg". It provides about +10 dB boost to sound level and a user facing microphone stereo beam that improves signal-to-noise ratio. The user space controls are disabled by default, so the user needs to set the features on with alsamixer or amixer conmmands. The 4ch topologies are set with passthrough blob for beamformer. With a lot of variation in array form factors there is no generic setting available. The DRC setting is the same for 4ch and provides +10 dB boost. The impacted topologies are: - sof-ptl-rt722-4ch Signed-off-by: Seppo Ingalsuo <[email protected]>
|
This should fix issue #9681 |
|
The change adds the beamformer (TDFB) and dynamic range control (DRC) to PCH DMIC capture host pipeline:
|
bardliao
approved these changes
Nov 28, 2024
lgirdwood
approved these changes
Nov 28, 2024
|
SOFCI TEST |
The existing default is high-pass 40 Hz with 0 dB gain. This change amplifies captured sound from DMIC by 20 dB. The same amplifying IIR type is used in hda-generic. The change is for now, but not the final solution. After we have UCM2 control for capture processing in SOF we can shift applying more gain to the DRC component that will provide more robustness with silent and loud environments. Signed-off-by: Seppo Ingalsuo <[email protected]>
|
Added 3rd commit, the comment and the new example recording from #9681 indicates that more amplification is needed. |
lgirdwood
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.