Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topology2: Add topology support for PDM0 DMIC with HDA codec for PTL #9696

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

udaymb
Copy link
Contributor

@udaymb udaymb commented Nov 29, 2024

This entry creates a topology for the HDA codec with PDM0 DMIC for PTL.

This entry creates a topology for the HDA codec with PDM0 DMIC
for PTL.

Signed-off-by: Uday M Bhat <[email protected]>
@@ -63,6 +63,12 @@ PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-hda-generic-ace1-2ch.bin,\
DMIC0_ENHANCED_CAPTURE=true,EFX_DMIC0_TDFB_PARAMS=line2_generic_pm10deg,\
EFX_DMIC0_DRC_PARAMS=dmic_default"

# HDA + HDMI + DMICs for PTL
"sof-hda-generic\;sof-hda-generic-ace3-2ch\;PLATFORM=ptl,HDA_CONFIG=mix,NUM_DMICS=2,\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACE3 should use the existing ace1 topology file if a DMIC blob is needed.
We don't have separate set of topologies for LNL (ACE2) either, the DMIC blob is the same.

@singalsu, can you clarify this?

Copy link
Contributor

@ujfalusi ujfalusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, ACE3 needs new DMIC blob after all...

@singalsu
Copy link
Collaborator

OK, ACE3 needs new DMIC blob after all...

Yes it does, please add also build for ace2 tplg, they all are different HW IP.

Copy link
Collaborator

@singalsu singalsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @udaymb !

@ujfalusi
Copy link
Contributor

OK, ACE3 needs new DMIC blob after all...

Yes it does, please add also build for ace2 tplg, they all are different HW IP.

I tried to see the difference, but the blob is the same for all ACE platforms, the reserved bits/register handling is all done in zephyr driver, the blob parsing is identical. Also, @udaymb said that the ac1 blob works on PTL fine (which is not a surprise).

@singalsu
Copy link
Collaborator

OK, ACE3 needs new DMIC blob after all...

Yes it does, please add also build for ace2 tplg, they all are different HW IP.

I tried to see the difference, but the blob is the same for all ACE platforms, the reserved bits/register handling is all done in zephyr driver, the blob parsing is identical. Also, @udaymb said that the ac1 blob works on PTL fine (which is not a surprise).

No, it's not same, see:

https://github.com/alsa-project/alsa-utils/blob/d45a2be9eaba2bb75840ca7c19bccc4d6578270b/topology/nhlt/intel/dmic/dmic-process.c#L790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants