-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
topology2: Add topology support for PDM0 DMIC with HDA codec for PTL #9696
base: main
Are you sure you want to change the base?
Conversation
This entry creates a topology for the HDA codec with PDM0 DMIC for PTL. Signed-off-by: Uday M Bhat <[email protected]>
@@ -63,6 +63,12 @@ PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-hda-generic-ace1-2ch.bin,\ | |||
DMIC0_ENHANCED_CAPTURE=true,EFX_DMIC0_TDFB_PARAMS=line2_generic_pm10deg,\ | |||
EFX_DMIC0_DRC_PARAMS=dmic_default" | |||
|
|||
# HDA + HDMI + DMICs for PTL | |||
"sof-hda-generic\;sof-hda-generic-ace3-2ch\;PLATFORM=ptl,HDA_CONFIG=mix,NUM_DMICS=2,\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACE3 should use the existing ace1 topology file if a DMIC blob is needed.
We don't have separate set of topologies for LNL (ACE2) either, the DMIC blob is the same.
@singalsu, can you clarify this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, ACE3 needs new DMIC blob after all...
Yes it does, please add also build for ace2 tplg, they all are different HW IP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @udaymb !
I tried to see the difference, but the blob is the same for all ACE platforms, the reserved bits/register handling is all done in zephyr driver, the blob parsing is identical. Also, @udaymb said that the ac1 blob works on PTL fine (which is not a surprise). |
No, it's not same, see: |
This entry creates a topology for the HDA codec with PDM0 DMIC for PTL.