Missing lock in tx.go #207
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a missing lock in tx.go , after the transaction is done via the RPC , the wallet is not locked hence its kept open to be used without password. If the RPC is exposed an attacker can make tx request without password as the wallet is unlocked. It is recommended to put defer lock , after the tx is executed.
|
Thanks for bring this up, but we also have the |
|
This is true. But what if a user doesn't lock the wallet , in that case it will be open to attack. As a best practice and more cautious approach we should lock the wallet immediately. For example an attacker can keep bombarding transfer request on the RPC port , as the wallet will be unlock by node user that transaction will be successful. |
|
What are your thought on above scenario ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a missing lock in tx.go , after the transaction is done via the RPC , the wallet is not locked hence its kept open to be used without password. If the RPC is exposed an attacker can make tx request without password as the wallet is unlocked. It is recommended to put defer lock , so after the tx is executed wallet is locked again.