Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide controller result to PostProcessor functions #151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Inkdpixels
Copy link

This PR introduces the option that all @postprocessor decorators can access the result of the controller method.

This is useful as one could validate the returned result against a swagger schema inside a processor function.

@IkerZamora
Copy link

This makes total sense. Why is it not merged yet? @thiagobustamante

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #151 (262e676) into master (70a2716) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files          14       14           
  Lines        1070     1070           
  Branches      195      195           
=======================================
  Hits         1011     1011           
  Misses         59       59           
Impacted Files Coverage Δ
src/server/model/metadata.ts 100.00% <ø> (ø)
src/server/model/server-types.ts 100.00% <ø> (ø)
src/decorators/services.ts 100.00% <100.00%> (ø)
src/server/service-invoker.ts 92.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a2716...a11a257. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants