Revert "Third time is the charm: fix flaky test"

This reverts commit 24b9a0f.

internal/core/core_test.go

@@ -104,8 +104,10 @@ func TestPause(t *testing.T) {
 func TestPauseCancel(t *testing.T) {
 	resetCounters()
 
-	ctx, cancelCtx := context.WithCancel(context.Background())
-	cancelCtx()
+	const timeout = time.Second
+	// will be cancelled before the timeout
+	ctx, cancelCtx := context.WithTimeout(context.Background(), timeout/10)
+	defer cancelCtx()
 
 	callbackPreCalled := false
 	callbackPosCalled := false
@@ -118,7 +120,9 @@ func TestPauseCancel(t *testing.T) {
 	assert.Equal(t, callbackPreCalled, false)
 	assert.Equal(t, callbackPosCalled, false)
 	assert.Equal(t, notifier.notificationCount.Load(), 0)
-	assert.Equal(t, notifier.notificationCancelCount.Load(), 0)
+	// this may be called or not, because we are using the same ctx for the main
+	// loop and the pause
+	assert.GreaterOrEqual(t, notifier.notificationCancelCount.Load(), 0)
 }
 
 func TestPauseNilCallbacks(t *testing.T) {