Check that @config exists. Fixes #413 #528
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running cucumber gives the error: cannot load such file -- test/unit (LoadError)
These weren't supposed to make it into this PR
Error message is: ActiveRecord::StatementInvalid: NoMethodError: undefined method `[]' for nil:NilClass: from octopus/lib/octopus/abstract_adapter.rb:23:in `octopus_shard' from octopus/lib/octopus/abstract_adapter.rb:12:in `instrument' from vendor/bundle/ruby/2.3.0/gems/activerecord-4.2.11.1/lib/active_record/connection_adapters/abstract_adapter.rb:478:in `log' This has shown to surface in the ibm_db and sqlserver adapters.
|
Trying this from another angle too, hopefully IBM will accept my patch over there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #413. It depends on PR #526 only just for running the tests. The real fix is just a one-liner to check that
@configexists in the database adapter. If it doesn't exist, the only side effect is that the message[Shard: name]isn't prepended to the query log.It appears that database adapters like ibm_db and sqlserver do not use an internal config variable called
@config, and the consequence is that the rails startup breaks. This quick patch at least gets people up and running.I'm working on a more elegant fix in https://github.com/calh/octopus/tree/ibm_db, but it's not going very well. The ibm_db gem breaks on rails 5.2. I think the only two options around this would be to pull Rails 5.2 support in octopus, or try to pursue a fix in the ibm_db gem. I'd appreciate any advice on this!