feat: add support for firefox #427
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow firefox support would be amazing, thank you ❤️. Also really like the change to move away from the CRXJS plugin. Unfortunately I don't have much time at the moment, I'll review and test in a few weeks. |
|
No worries, take your time :) Let me know if you'd prefer the PR to be split into more detailed commits. Also, I'm not entirely confident about the test fixes—maybe you have a better idea on how to prevent the polyfill being loaded when running the tests. See you in chat! 🎱📖 |
Replaced all calls to the Chrome API with calls to the webextension-polyfill. In Manifest v3, Firefox still uses background.scripts instead of background.service_worker. To ensure compatibility with both browsers, we include both entries in the manifest file. The unsupported entry will be ignored, but may trigger a warning in developer mode.
`webextension-polyfill` can only be loaded in browser contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRXJStoVite Plugin Web Extension.webextension-polyfillinstead of Chrome API.In Manifest v3, Firefox still uses background.scripts instead of background.service_worker. To ensure compatibility with both browsers, we include both entries in the manifest file. The unsupported entry will be ignored, but may trigger a warning in developer mode.