Skip to content

Commit

Permalink
feat: started work on fix type of check for ranges rule
Browse files Browse the repository at this point in the history
FossilOrigin-Name: cb2fe24adbd017473f82417b78e67dda3a66a82c78a0b7cd6bbfb115d94c4140
  • Loading branch information
thindil committed Aug 8, 2024
1 parent ab05b72 commit 6c4703b
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 12 deletions.
23 changes: 20 additions & 3 deletions src/rules/ranges.nim
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ checkRule:
let rangeLine: FileLine = fileContent[node.info.line.Natural - 1]
setResult(checkResult = rangeLine[rangeLine.find(sub = "..") - 1] ==
' ', positiveMessage = positiveMessage,
negativeMessage = negativeMessage, ruleData = "", node = node,
params = [$node.info.line, hasMessage &
negativeMessage = negativeMessage, ruleData = $node.info.line,
node = node, params = [$node.info.line, hasMessage &
" spaces between start and end of the range"])
except IOError, Exception:
rule.amount = errorMessage(text = messagePrefix & "can't check file '" &
Expand All @@ -105,4 +105,21 @@ checkRule:
discard

fixRule:
discard

let newFileName: FilePath = rule.fileName & ".bak"
try:
moveFile(source = rule.fileName, dest = newFileName)
let newFile: File = open(filename = rule.fileName, mode = fmWrite)
newFile.close
except OSError, IOError, Exception:
discard errorMessage(text = "Can't fix file '" &
rule.fileName & ". Reason: ", e = getCurrentException())
try:
removeFile(file = rule.fileName)
except OSError:
discard
try:
moveFile(source = newFileName, dest = rule.fileName)
except IOError, OSError, Exception:
discard
return false
9 changes: 0 additions & 9 deletions tests/valid/ranges.nim
Original file line number Diff line number Diff line change
@@ -1,9 +0,0 @@
# Count: 2
# Negative count: 0

type a = range[0 .. 5]

let b = "werew..wer"

for i in 1 .. 6:
echo i

0 comments on commit 6c4703b

Please sign in to comment.