Small linux changes #50
Conversation
| @@ -42,9 +42,10 @@ | |||
| </p> | |||
| <p class="code"> | |||
| sudo usermod -a -G dialout $USER | |||
| sg dialout "npm start" | |||
There was a problem hiding this comment.
When you download the binaries "npm start" won't be the executable. What does this command do exactly?
There was a problem hiding this comment.
It's a cousin of the newgrp(1) tool that logs into a new group. sg(1) let's you run a command as a different group, so you don't really need to log off or reboot in this case.
There was a problem hiding this comment.
Maybe we should leave this line out then because there could be different groups and I'm unsure what command we would run... maybe "flasher.js" but I don't know to be precise. I guess people can log in and out quickly
| success(); | ||
| const groups = stdout; | ||
| if (groups.match(/(dialout|tty|uucp)/)) { | ||
| success(); | ||
| } else { | ||
| const dialoutMissingError = new Error(ERROR_MESSAGES.USER_NOT_IN_DIALOUT); |
There was a problem hiding this comment.
Can you update the Error message to match the tty and uucp groups too?
| @@ -42,9 +42,10 @@ | |||
| </p> | |||
| <p class="code"> | |||
| sudo usermod -a -G dialout $USER | |||
There was a problem hiding this comment.
In other distros does it need to be tty or uucp instead of dialout?
There was a problem hiding this comment.
Yes, but I didn't want to make the message too long. Should I clarify it?
There was a problem hiding this comment.
Maybe we can sniff the distros to get a sane message to give?
I added more groups to the serial device, to make it work with other distributions.
No need to reboot so I added the sg command instead.