Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed directory name that was causing errors during cloning #1161

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

DebdipWritesCode
Copy link
Contributor

@DebdipWritesCode DebdipWritesCode commented Oct 31, 2024

Developer Checklist

  • Followed guidelines mentioned in the README file.
  • Followed directory structure. (e.g. ProjectName/{USERNAME}/...yourfiles)
  • Starred ⭐ the Repo (Optional)

Summary

Renamed the folder SpendingCalculatorApp:Pratik1968 to SpendingCalculatorApp_Pratik1968 to remove unsupported characters and improve compatibility across different systems. This update addresses a fundamental issue that may prevent successful cloning and checkout on systems with stricter filename character restrictions.

Additionally, we made several changes to enhance the user experience and code quality:

  • Changed the mistakenly used <z> tag to the correct <p> tag for semantic accuracy.
  • Fixed the .join issue that was causing a TypeError due to null values in the Cards component.
  • Added content for the home page, including a welcoming heading and a description of the project.
  • Implemented a "See Projects" button for easier navigation to the /projects route.
  • Added basic fade-in animations for the <h1> and <p> tags on the home page to improve visual engagement.
  • Adjusted the font size of the navbar text for better fitting and readability.

This is a basic but essential fix that ensures smoother usage and compatibility for contributors and users alike.

_attached screenshots

Screenshot 2024-10-31 193914

Copy link
Collaborator

@NitkarshChourasia NitkarshChourasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

Copy link
Collaborator

@NitkarshChourasia NitkarshChourasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@NitkarshChourasia NitkarshChourasia merged commit 84ac88e into thinkswell:master Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants