Consider allowing host.docker.internal with the http protocol for local development #886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
isValidWebhookUrl
to allow using host.docker.internal with thehttp
protocolhttp://host.docker.internal:3000
is a valid webhook urlThis makes it possible to set webhooks for services running on the host when developing locally and running the engine with docker
PR-Codex overview
This PR updates the validation logic for webhook URLs to include
host.docker.internal
as a valid hostname for HTTP requests, enhancing local development compatibility.Detailed summary
tests/unit/validator.test.ts
to validatehttp://host.docker.internal:3000
.src/server/utils/validator.ts
to includehost.docker.internal
in the list of allowed hostnames for HTTP.