Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip installation #45

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

SengerM
Copy link
Contributor

@SengerM SengerM commented Oct 24, 2024

@thliebig
Copy link
Owner

thliebig commented Nov 3, 2024

How does this solve where to find the necessary binaries? Especially on Windows? Usually the user would expect that after "pip install CSXCAD" everything needed gets installed?
I guess this still needs to have CSXCAD/openEMS installed in some way beforehand? I guess we just have to accept that?

@SengerM
Copy link
Contributor Author

SengerM commented Nov 3, 2024

It does not solve that, unfortunately. TBH, I don't know how to make it better, other than shipping everything together with predefined paths in some installation script, or so.

@thliebig
Copy link
Owner

thliebig commented Nov 9, 2024

@SengerM can you have a look at the conflict?

@thliebig
Copy link
Owner

I do not like the enforcement of the environment variable... This is not how I prefer to build the python extension (during development) and I think this would break the current build process used by openEMS and potentially other tools depending on CSXCAD...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants