Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Math-Checker] Make Math-Parser transformers modular #1165

Merged
merged 6 commits into from
Feb 23, 2023
Merged

[Math-Checker] Make Math-Parser transformers modular #1165

merged 6 commits into from
Feb 23, 2023

Conversation

Zitrone44
Copy link
Member

closes #1099

@Zitrone44
refactor!(math-parser): make math parser transformers modular
1c7aae6 
BREAKING CHANGE: SemanticAstComparator now takes arguments to configure which expressions are equal. The default behavior is therefor stricter than before.
@Zitrone44
feat(math-parser): add sac builder for better usage from non kotlin code
d4fb8dc
@Zitrone44 Zitrone44 requested a review from mxsph February 14, 2023 08:51
@Zitrone44 Zitrone44 requested a review from a team as a code owner February 14, 2023 08:51
pdrtzk
pdrtzk previously approved these changes Feb 17, 2023
View reviewed changes
@mxsph mxsph merged commit c8e5e42 into dev Feb 23, 2023
@mxsph mxsph deleted the i1099-modular-math-checkeer branch February 23, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxsph mxsph mxsph approved these changes

@pdrtzk pdrtzk pdrtzk left review comments

Assignees
No one assigned
Labels
checker: math
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mathe-Checker] Modularization of Math-Checker
3 participants
@Zitrone44 @pdrtzk @mxsph