-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shiny progress support #331
base: main
Are you sure you want to change the base?
Conversation
Hi @schuelkem, when i try to run your code, i get the following error: Warning: Error in device: unused argument (update_progress = function (detail) Is there some piece of code that i'm missing? I have an animated line plot based on 100 rendered frames and am looking for a progress bar to alert users that work is happening in the background. I'm fairly certain that's what this is supposed to do (still a newbie). Can you help clarify what's missing here? |
Hi @jschoeneberger, I get the same error when I try to run my example app using an install of gganimate from the master branch of thomasp85/gganimate. The example app above requires a different version of gganimate to function. That version is a fork at schuelkem/gganimate. To install use |
Thanks a lot @schuelkem ! This works just fine, now...both with your example and in my app. Much appreciated! |
This works on my local machine, but when I deploy the app on shinyapps.io, I get error. Any idea to fix it? |
I'm not sure what to say...i'd try removing the old version and using a clean devtools installation. Good luck! |
Any news? |
Added support for shiny progress indicator based on the RStudio complex example. This pull request directly addresses issue #305 and partially addresses issue #272.
Comments were used in the travis yaml to avoid a pull-irrelevant build error involving deployment keys back to Github. I guess this change also resulted in the codecov errors. These changes can and should be ignored.
Progress message and detail were coded to best match the
progress::progress_bar
message usingprettyunits::vague_dt()
, but the decision to includeprettyunits
as a dependency is left up for debate. As it stands now, the user will have tolibrary(prettyunits)
in their app code to make this work.This solution also requires the length of the progress bar in frames to be determined and set when making the
shiny::Progress
object and this value should also be passed toannimate()
.Example app: