Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a search bar to website #336

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Add a search bar to website #336

merged 4 commits into from
Jan 5, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Oct 5, 2023

Update pkgdown config.

Here is the new look
image

@olivroy
Copy link
Contributor Author

olivroy commented Jan 5, 2024

@thomasp85, if you prefer, I can break this down in smaller PRs? and just add this to _pkgdown.yml in this one.

template:
  bootstrap: 5

@thomasp85
Copy link
Owner

Nah, this is fine - maybe just leave the DESCRIPTION file alone as that isn't relevant to this

@olivroy
Copy link
Contributor Author

olivroy commented Jan 5, 2024

Done, thanks! I just left the Config/Needs/website: gifski as it is recommended to declare dependencies in DESCRIPTION rather than in GitHub actions.

@thomasp85
Copy link
Owner

Yes for sure - thanks a bunch!

@thomasp85 thomasp85 merged commit e6a7dcd into thomasp85:main Jan 5, 2024
14 checks passed
@olivroy olivroy deleted the site branch January 5, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants