Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire event when subtitle changes #12

Merged
merged 2 commits into from
Jul 9, 2014
Merged

Conversation

alexismo
Copy link
Contributor

@alexismo alexismo commented Jul 7, 2014

This changes solves issue #9. It makes a "subtitlechanged" event available every time the content of a subtitle is changed. The event contains information about the event, such as:

  • the div where the text should go
  • the video
  • timecode at which the event happened
  • content of the new subtitle

I needed this feature in some of my code. Thought you might want to integrate it.

thomassturm added a commit that referenced this pull request Jul 9, 2014
Fire event when subtitle changes
@thomassturm thomassturm merged commit 5410d8f into thomassturm:master Jul 9, 2014
@thomassturm
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants